chore: rename PythonStandardRunner #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is lower priority, but it has been pointed out to me that `PythonStandardRunner` is not accurate. There are other test runners available in python after all. So these changes simple rename it to be `PytestStandardRunner` instead. Include changes to default options to the `--runner` option and the config key for the runner. I made that to be backwards compatible tho.
giovanni-guidini
requested review from
dana-yaish,
joseph-sentry,
matt-codecov and
scott-codecov
Codecov Report
@@ Coverage Diff @@
## main #280 +/- ##
==========================================
+ Coverage 95.35% 95.49% +0.14%
==========================================
Files 78 79 +1
Lines 2646 2730 +84
==========================================
+ Hits 2523 2607 +84
Misses 123 123
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dana-yaish
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is lower priority, but it has been pointed out to me that
PythonStandardRunneris not accurate. There are other test runners available in python after all.
So these changes simple rename it to be
PytestStandardRunnerinstead.Include changes to default options to the
--runneroption and the config keyfor the runner. I made that to be backwards compatible tho.